[pbs-devel] applied-series: [PATCH proxmox-backup 0/2] fix 2 issues with s3 store verifies

[Fabian Grünbichler]

although that nested match there would benefit from some refactoring,
and I am also not 100% sure we shouldn't add some additional checks to
the flow there (e.g., heal the S3 chunk if the local one is correct,
verify the local one is correct in addition to the S3 one, ensure
renaming happens even if either side is missing the "corrupt" chunk?)

On October 29, 2025 12:06 pm, Christian Ebner wrote:
> This patches were pulled out from the original patch series [0] since
> they are independent from the bigger series attempting to fix the
> possible race between corrupt chunk renaming and chunk insert/upload
> and better reviewed/tested independently.
> 
> Patch 1 makes sure the mutex guard to sync up access to the corrupt
> chunk list is dropped before attempting to rename a corrupt chunk,
> which will call into async context on s3 stores. Otherwise deadlock
> can arise.
> 
> Patch 2 is a followup to the bugfix for issue #6665, which however
> did not correctly distinguish between transient fetching errors and
> the possible chunk DataBlob decoding error from the response body in
> case of a successful response.
> 
> [0] https://lore.proxmox.com/pbs-devel/20251016131819.349049-6-c.ebner@proxmox.com/T/
> 
> Christian Ebner (2):
>   verify: never hold mutex lock in async scope on corrupt chunk rename
>   verify: distinguish s3 object fetching and chunk loading error
> 
>  src/backup/verify.rs | 34 +++++++++++++++++++---------------
>  1 file changed, 19 insertions(+), 15 deletions(-)
> 
> -- 
> 2.47.3
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>