[pbs-devel] partially-applied: [PATCH proxmox-backup v2 0/3] fix GC atime update race window

[Thomas Lamprecht]

On Thu, 06 Nov 2025 18:13:55 +0100, Christian Ebner wrote:
> Sweeping of unused chunks during garbage collection checks their
> atime to distinguish between chunks being in-use and chunks no
> longer being used. While garbage collection does lock the chunk
> store by guarding its mutex before reading file stats and deleting
> unused chunks, the conditional touch did not do this before updating
> the chunks atime (thereby also checking the presence).
> 
> [...]

Applied the first two patches, thanks!

For the third one I would rather like an actual review from Fabian, especially
w.r.t. adding the callback.

[1/3] chunk store: limit scope for atime update helper methods
      commit: 5799bcda53220c78ff45a44e5b58582a0fac2e83
[2/3] chunk store: fix race window between chunk stat and gc cleanup
      commit: d45077366778c20293901b5e3ef36725cf123f88
[3/3] datastore: insert chunk marker and touch bad chunks in locked context
      SKIPPED