[pbs-devel] [PATCH] api: sync: list `all` instead of only `pull` synch jobs by default

[Christian Ebner]

On 11/5/25 3:14 PM, Thomas Lamprecht wrote:
> Am 04.11.25 um 09:58 schrieb Christian Ebner:
>> On 11/4/25 8:34 AM, Hannes Laimer wrote:
>>> There is no reason to still default to only listing pulling jobs.
>>
>> Well, this was overlooked for PBS 4.0, but I'm afraid the change needs to be postponed to PBS version 5.0, as this is a breaking API change.
>>
> 
> This really just listing the specific job types IIUC?
 >> Returning new stuff is generally not a breaking change, here it was done
> to avoid confusing clients that are to old [0]. Albeit I'm now actually
> wondering which client can get confused? Third party integrations? As
> our CLI client has no support for managing sync jobs from a PBS, and the
> web UI might only have issues when a outdated version was loaded from the
> cache.

Yes, now all the sync jobs would be returned when no specific direction 
was specified. Therefore this might cause issues for api consumers which 
do not expect that.

But fallout from this is probably rather limited and easily fixed on 
consumer side by also providing the flag to only list pull sync jobs 
again if required.
> Anyhow, even if I'm overlooking something now: while we want to have good
> forward compatibility support, especially for point releases from the same
> major release, this was introduced for PBS 3.3 about year ago. This means
> all officially supported clients and PBS support it, and as it's not related
> to backup protocol (write or restore), I really do not think we should let
> us hold back here, as in practice nothing will change w.r.t. compat compared
> to changing this already for 4.0 proper, and – again, if I do not miss
> something – this change really seems unproblematic in general.
> 
> [0]: commit 403ad1f6d ("api: admin: sync: add optional 'all' sync type for
>       listing")