[pbs-devel] applied: [PATCH proxmox] schema: drop leftover useless i64 check

Wolfgang Bumiller w.bumiller at proxmox.com
Wed Nov 5 14:54:16 CET 2025


applied, thanks

On Tue, Oct 14, 2025 at 12:24:12PM +0200, Fabian Grünbichler wrote:
> since 7ac306e268e2840d258af41ce8cec890fc372351 IntegerSchema is no longer
> isize, but i64, so this check is pointless.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> clippy complained about the useless conversion here, sending on-list in case I
> missed something..
> 
>  proxmox-schema/src/de/mod.rs | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/proxmox-schema/src/de/mod.rs b/proxmox-schema/src/de/mod.rs
> index 1f14503e..ea2115c5 100644
> --- a/proxmox-schema/src/de/mod.rs
> +++ b/proxmox-schema/src/de/mod.rs
> @@ -180,9 +180,6 @@ impl<'de> de::Deserializer<'de> for SchemaDeserializer<'de, '_> {
>  
>                  schema.check_constraints(value).map_err(Error::invalid)?;
>  
> -                let value: i64 = i64::try_from(value)
> -                    .map_err(|_| Error::invalid("isize did not fit into i64"))?;
> -
>                  if let Ok(value) = u64::try_from(value) {
>                      visitor.visit_u64(value)
>                  } else {
> -- 
> 2.47.3




More information about the pbs-devel mailing list