[pbs-devel] [PATCH] api: sync: list `all` instead of only `pull` synch jobs by default

Hannes Laimer h.laimer at proxmox.com
Tue Nov 4 08:34:02 CET 2025


There is no reason to still default to only listing pulling jobs.

Reported-by: https://forum.proxmox.com/threads/pbs-api-aufruf.175211/
Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
---
 src/api2/admin/sync.rs | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/api2/admin/sync.rs b/src/api2/admin/sync.rs
index 6722ebea..c21a6909 100644
--- a/src/api2/admin/sync.rs
+++ b/src/api2/admin/sync.rs
@@ -23,18 +23,17 @@ use crate::{
     server::sync::do_sync_job,
 };
 
-// FIXME: 4.x make 'all' the default
 #[api()]
 #[derive(Copy, Clone, Debug, Default, Eq, PartialEq, Serialize, Deserialize)]
 #[serde(rename_all = "kebab-case")]
 /// The direction of the listed sync jobs: push, pull or all.
 pub enum ListSyncDirection {
     /// All directions
+    #[default]
     All,
     /// Sync direction push
     Push,
     /// Sync direction pull
-    #[default]
     Pull,
 }
 
-- 
2.47.3





More information about the pbs-devel mailing list