[pbs-devel] [PATCH proxmox{, -widget-toolkit, -backup} 0/4] notifications: add support for nested matchers
Lukas Wagner
l.wagner at proxmox.com
Wed May 21 16:23:05 CEST 2025
This series adds support for nested notification matchers. A new match rule is
added, 'eval-matcher', which allows to evaluate other matchers and use their
result in the current matcher.
Any matcher that shall be used as a nested matcher must have the (new) `nested`
flag set to true. These matchers are only evaluated if they are referenced
by another matcher. Any target configured for a nested matcher is ignored,
only the 'top-level'/'outermost' matcher decides which targets to notify.
This patch series includes:
- patches for proxmox-notify, which add the new config entries for matchers,
API methods and nested matcher evaluation
- patches for proxmox-backup, which contain documentation for the new
feature
- patches for proxmox-widget-toolkit, containing the GUI changes needed
for this feature.
Small config example:
matcher: top-level
target mail-to-root
mode any
eval-matcher a
eval-matcher b
matcher: a
nested true
mode all
match-field exact:datastore=store
match-field exact:type=gc
match-severity error
matcher: b
nested true
mode all
match-field exact:datastore=store
match-field exact:type=prune
match-severity error
The GUI remains functional if changes of proxmox-widget-toolkit are rolled out
before the proxmox-notify/proxmox-backup ones, so we should get away without
any sort of versioned break between widget-toolkit and proxmox-backup. Matchers
can be added/modified/deleted without problems, only if one tries to add a
nested-matcher rule or declare a matcher as a nested matcher an error is
displayed. Everything else should work.
Patches for PVE will follow once the core elements for this series have been
reviewed.
Note:
The patches for proxmox-notify are based on the `stable-bookworm` branch.
## Patch series revisions:
v1: you are here
proxmox:
Lukas Wagner (2):
notify: matcher: allow to evaluate other matchers via `eval-matcher`
notify: matcher: API: update methods for nested matcher support
proxmox-notify/src/api/matcher.rs | 229 +++++++++++++++++++++-
proxmox-notify/src/api/mod.rs | 4 +
proxmox-notify/src/lib.rs | 20 +-
proxmox-notify/src/matcher.rs | 313 ++++++++++++++++++++++++++++--
4 files changed, 532 insertions(+), 34 deletions(-)
proxmox-widget-toolkit:
Lukas Wagner (1):
notifications: matchers: add nested matcher support
src/data/model/NotificationConfig.js | 8 +-
src/panel/NotificationConfigView.js | 6 +
src/window/NotificationMatcherEdit.js | 220 +++++++++++++++++++++++++-
3 files changed, 232 insertions(+), 2 deletions(-)
proxmox-backup:
Lukas Wagner (1):
docs: notifications: add section about nested matchers
docs/notifications.rst | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
Summary over all repositories:
8 files changed, 787 insertions(+), 36 deletions(-)
--
Generated by git-murpp 0.8.1
More information about the pbs-devel
mailing list