[pbs-devel] [RFC proxmox-backup 17/39] api: backup: conditionally upload blobs to S3 object store backend

Christian Ebner c.ebner at proxmox.com
Mon May 19 13:46:18 CEST 2025


Upload blobs to both, the local datastore cache and the S3 object
store if s3 is configured as backend.

Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
---
 src/api2/backup/environment.rs | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/src/api2/backup/environment.rs b/src/api2/backup/environment.rs
index 8919b919a..393a8351d 100644
--- a/src/api2/backup/environment.rs
+++ b/src/api2/backup/environment.rs
@@ -581,6 +581,31 @@ impl BackupEnvironment {
         let blob = DataBlob::load_from_reader(&mut &data[..])?;
 
         let raw_data = blob.raw_data();
+        if let DatastoreBackend::S3(s3_client) = &self.backend {
+            let data = Body::from(raw_data.to_vec());
+            let mut object_key = self.backup_dir.relative_path();
+            object_key.push(file_name);
+            let object_key = object_key
+                .as_os_str()
+                .to_str()
+                .ok_or_else(|| format_err!("invalid path"))?;
+            match proxmox_async::runtime::block_on(s3_client.put_object(object_key.into(), data))? {
+                PutObjectResponse::PreconditionFailed => {
+                    self.log(format!(
+                        "Upload of blob failed, object {object_key} already present."
+                    ));
+                    bail!("upload of blob failed");
+                }
+                PutObjectResponse::NeedsRetry => {
+                    self.log("Upload of blob failed, reupload required.");
+                    bail!("concurrent operation, reupload required");
+                }
+                PutObjectResponse::Success(_content) => {
+                    self.log(format!("Uploaded blob to object store: {object_key}"))
+                }
+            }
+        }
+
         replace_file(&path, raw_data, CreateOptions::new(), false)?;
 
         self.log(format!(
-- 
2.39.5





More information about the pbs-devel mailing list