[pbs-devel] [PATCH proxmox-backup 0/5] prefilter source list by verify state for sync jobs

Christian Ebner c.ebner at proxmox.com
Fri May 16 13:54:24 CEST 2025


Since the introduction of the `verified-only` and `encrypted-only`
optional parameters for sync jobs, it is possible to exclude snapshot
if their are not encrypted or verified from the sync.

The current implementation, filtering the snapshots based on the
manifest information only directly before syncing said snapshot, leads
to the somewhat unexpected behaviour that in combination with the
transfer-last parameter set, the transfer-last filtering is performed
before the encryption/verificaton state filtering.

This patch series improves the current behaviour by pre-filtering the
snapshots already when generating the list of to be synced items.
This allows to apply the transfer-last filtering only after the
verified-only and encrypted-only filters, resulting in a more natural
behaviour.

Since this breaks with the current filter order, the breaking changes
should be considered for version 4 only.

Christian Ebner (5):
  api: admin: refactor generation of backup dir for snapshot listing
  api: factor out helper converting backup info to snapshot list item
  sync: source: list snapshot items instead of backup directories
  pull: refactor source snapshot list filtering logic
  sync: conditionally pre-filter source list by verified or encrypted
    state

 src/api2/admin/datastore.rs | 142 +++---------------------------------
 src/server/pull.rs          |  49 ++++++++-----
 src/server/push.rs          |  44 +++++++----
 src/server/sync.rs          |  73 +++++++++++++-----
 src/tools/mod.rs            | 129 ++++++++++++++++++++++++++++++++
 5 files changed, 252 insertions(+), 185 deletions(-)

-- 
2.39.5





More information about the pbs-devel mailing list