[pbs-devel] [PATCH proxmox/proxmox-backup v2 0/8] trigger sync jobs on mount

Hannes Laimer h.laimer at proxmox.com
Thu May 15 14:41:30 CEST 2025


Sync jobs now have a run-on-mount flag, that, if set, runs the job whenever
a relevant removable datastore is mounted. 

This depends on [1], without it the api process does not drop the file
handle on the `.lock` file which leads to the datastore being not
unmountable after sync jobs were triggered. (now thinking about it,
might have made sense to include it in this series directly, but it also
does make sense on its own)

v2, thanks @Chris:
- rebased onto master
- improve some docstrings
- move/fix config flag
- drop not-needed changes for the manager binary
- ui: move checkbox to advenced section + don't clear schedule field
- fix test
- actually check the configured flag when deciding if a job should
  run...

[1] https://lore.proxmox.com/pbs-devel/20250512125933.156192-1-h.laimer@proxmox.com/T/#u


proxmox:
Hannes Laimer (2):
  rest-server: add function that returns a join handle for spawn
  pbs-api-types: add run-on-mount flag to SyncJobConfig

 pbs-api-types/src/jobs.rs              |  8 ++++++++
 proxmox-rest-server/src/worker_task.rs | 24 ++++++++++++++++++++++--
 2 files changed, 30 insertions(+), 2 deletions(-)

proxmox-backup:
Hannes Laimer (6):
  api: config: sync: update run-on-mount correctly
  api: admin: run configured sync jobs when a datastore is mounted
  api: admin: trigger sync jobs only on datastore mount
  bin: manager: run uuid_mount/mount tasks on the proxy
  ui: add run-on-mount checkbox to SyncJob form
  ui: add task title for triggering sync jobs

 src/api2/admin/datastore.rs                 | 97 +++++++++++++++++++--
 src/api2/admin/sync.rs                      |  2 +-
 src/api2/config/sync.rs                     |  9 ++
 src/bin/proxmox_backup_manager/datastore.rs | 41 ++++++---
 src/server/sync.rs                          |  7 +-
 www/Utils.js                                |  1 +
 www/window/SyncJobEdit.js                   | 13 ++-
 7 files changed, 148 insertions(+), 22 deletions(-)

-- 
2.39.5





More information about the pbs-devel mailing list