[pbs-devel] [RFC v2 proxmox-backup 16/21] api: datastore: add flag to list trashed snapshots only

Fabian Grünbichler f.gruenbichler at proxmox.com
Mon May 12 12:01:54 CEST 2025


On May 12, 2025 9:57 am, Christian Ebner wrote:
> On 5/9/25 14:27, Fabian Grünbichler wrote:
>> On May 8, 2025 3:05 pm, Christian Ebner wrote:
>>> Allows to conditionally show either active or trashed backup
>>> snapshots, the latter being used when displaying the contents of the
>>> trash for given datastore.
>> 
>> and what if I want to list both/all?
> 
> Did not include that option/variant as not required for the WebUI and 
> possible to achieve by 2 API calls instead of a single one with the 
> respective flags.

well, doing two API calls means I then have to check for changed state
and merge the results as a client.. 

> Further, listing both of them with the same call would require to add a 
> trash flag to the response item type, which I tried to avoid.

we could only include the trash marker in the serialized result if it is
set?

> Do we require to be able to list both with the same api call?

I think it makes for a better interface..




More information about the pbs-devel mailing list