[pbs-devel] applied: [PATCH proxmox-backup v2] api: config: use guard for unmounting on failed datastore creation
Thomas Lamprecht
t.lamprecht at proxmox.com
Thu Mar 20 18:46:32 CET 2025
Am 20.03.25 um 13:11 schrieb Hannes Laimer:
> Currently if any `?`/`bail!` happens between mounting and completing
> the creation process unmounting will be skipped. Adding this guard
> solves that problem and makes it easier to add things in the future
> without having to worry about a disk not being unmounted in case of a
> failed creation.
>
> Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
> Reported-by: Wolfgang Bumiller <w.bumiller at proxmox.com>
> ---
> v2, thanks @Wolfgang:
> - replace `should_unmount` flag with wrapping path in an Option
>
> src/api2/config/datastore.rs | 82 +++++++++++++++++++++---------------
> 1 file changed, 48 insertions(+), 34 deletions(-)
>
>
applied, with Christian's T-b, thanks!
More information about the pbs-devel
mailing list