[pbs-devel] [PATCH v5 proxmox-backup 7/8] ui: expose GC atime cutoff in datastore tuning option

[Thomas Lamprecht]

Am 06.03.25 um 15:52 schrieb Christian Ebner:
> Allows to set the atime cutoff for phase 2 of garbage collection in
> the datastores tuning parameters. This value changes the time after
> which a chunk is not considered in use anymore if it falls outside of
> the cutoff window.
> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> changes since version 4:
> - no changes
> 
>  www/Utils.js                | 5 +++++
>  www/datastore/OptionView.js | 9 +++++++++
>  2 files changed, 14 insertions(+)
> 
> diff --git a/www/Utils.js b/www/Utils.js
> index 9bd7e1615..13b5eceda 100644
> --- a/www/Utils.js
> +++ b/www/Utils.js
> @@ -850,6 +850,11 @@ Ext.define('PBS.Utils', {
>  	delete tuning['gc-atime-safety-check'];
>  	options.push(`${gettext('GC Access Time Safety Check')}: ${gc_atime_safety_check ?? true}`);
>  
> +	let gc_atime_cutoff = tuning['gc-atime-cutoff'];
> +	delete tuning['gc-atime-cutoff'];
> +	gc_atime_cutoff = gc_atime_cutoff ?? '1445';
> +	options.push(`${gettext('GC Access Time Cutoff')}: ${gc_atime_cutoff}m`);
> +
>  	for (const [k, v] of Object.entries(tuning)) {
>  	    options.push(`${k}: ${v}`);
>  	}
> diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
> index 9ce3ce388..9e8dcc4fb 100644
> --- a/www/datastore/OptionView.js
> +++ b/www/datastore/OptionView.js
> @@ -279,6 +279,15 @@ Ext.define('PBS.Datastore.Options', {
>  			    uncheckedValue: 0,
>  			    deleteDefaultValue: true,
>  			},
> +			{
> +			    xtype: 'proxmoxintegerfield',
> +			    emptyText: Proxmox.Utils.defaultText,

This won't change that soon I think, so we could convey the actual default
value, like e.g.:

gettext('1445 (24 hours 5 minutes)'),

> +			    name: 'gc-atime-cutoff',

tiny nit, I prefer ordering of properties such that xtype and name come first,
as normally those are the most important options w.r.t. what this is and how
it will be submitted. It's nice to get the label then afterward, but way less
hard feelings there.

> +			    minValue: 1,
> +			    maxValue: 2880,
> +			    fieldLabel: gettext('GC Access Time Cutoff (min)'),
> +			    deleteEmpty: true,
> +			},
>  		    ],
>  		},
>  	    },