[pbs-devel] [PATCH v3 proxmox 2/2] pbs api types: add option to set GC chunk cleanup atime cutoff
Christian Ebner
c.ebner at proxmox.com
Tue Mar 4 19:35:39 CET 2025
Add the `gc-atime-cutoff` option to the datastore tuning parameters.
This allows to specify the time after which the chunks are not
considered in use anymore if their atime has not been updated since
then. This option is only considered, if the `gc-atime-safety-check`
is enabled, to avoid potential data loss.
The default is to keep chunks within the 24h 5m timespan (given no
active writers).
Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
---
changes since version 2:
- rename datastore tuning parameter to be more specific
- adapt allowed values range to cover from 1 - 2880 minutes
pbs-api-types/src/datastore.rs | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index 1a4d9e2d..467417e8 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -223,6 +223,15 @@ pub enum DatastoreFSyncLevel {
Filesystem,
}
+pub const GC_ATIME_CUTOFF_SCHEMA: Schema = IntegerSchema::new(
+ "Cutoff (in minutes) for chunk cleanup atime check in garbage collection phase 2 \
+ (default 24h 5m)",
+)
+.minimum(1) // safety margin for kernel timestamp granularity, but stay within minute range
+.maximum(2880) // 2 days
+.default(1445)
+.schema();
+
#[api(
properties: {
"chunk-order": {
@@ -237,6 +246,10 @@ pub enum DatastoreFSyncLevel {
default: true,
type: bool,
},
+ "gc-atime-cutoff": {
+ schema: GC_ATIME_CUTOFF_SCHEMA,
+ optional: true,
+ },
},
)]
#[derive(Serialize, Deserialize, Default)]
@@ -250,6 +263,8 @@ pub struct DatastoreTuning {
pub sync_level: Option<DatastoreFSyncLevel>,
#[serde(skip_serializing_if = "Option::is_none")]
pub gc_atime_safety_check: Option<bool>,
+ #[serde(skip_serializing_if = "Option::is_none")]
+ pub gc_atime_cutoff: Option<usize>,
}
pub const DATASTORE_TUNING_STRING_SCHEMA: Schema = StringSchema::new("Datastore tuning options")
--
2.39.5
More information about the pbs-devel
mailing list