[pbs-devel] [PATCH proxmox-backup 8/9] ui: datastore options: drop notify and notify-user rows

[Lukas Wagner]

Even if the notification mode is set to 'notification-system', the
datastore options grid still shows the keys for 'Notify' and 'Notify
User', which have no effect in this mode:

        Notification:      [Use global notification settings]
        Notify:            [Prune: Default(always), etc...]
        Notify User:       [root at pam]

This is quite confusing.

Unfortunately, it seems be quite hard to dynamically disable/hide rows
in the grid panel used in this view.

For that reason these rows are removed completely for now. The options
are still visible when opening the edit window for the 'Notification'
row.

While this slightly worsens UX in some cases (information is hidden), it
improves clarity by reducing ambiguity, which is also a vital part of
good UX.

Signed-off-by: Lukas Wagner <l.wagner at proxmox.com>
---
 www/datastore/OptionView.js | 25 -------------------------
 1 file changed, 25 deletions(-)

diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 5a10a65d..913bdfc7 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -179,31 +179,6 @@ Ext.define('PBS.Datastore.Options', {
                 xtype: 'pbsNotifyOptionEdit',
             },
         },
-        notify: {
-            required: true,
-            header: gettext('Notify'),
-            renderer: (value) => {
-                let notify = PBS.Utils.parsePropertyString(value);
-                let res = [];
-                for (const k of ['Verify', 'Sync', 'GC', 'Prune']) {
-                    let fallback = k === 'Prune' ? 'Error' : 'Always';
-                    let v = Ext.String.capitalize(notify[k.toLowerCase()]) || fallback;
-                    res.push(`${k}=${v}`);
-                }
-                return res.join(', ');
-            },
-            editor: {
-                xtype: 'pbsNotifyOptionEdit',
-            },
-        },
-        'notify-user': {
-            required: true,
-            defaultValue: 'root at pam',
-            header: gettext('Notify User'),
-            editor: {
-                xtype: 'pbsNotifyOptionEdit',
-            },
-        },
         'verify-new': {
             required: true,
             header: gettext('Verify New Snapshots'),
-- 
2.39.5