[pbs-devel] [PATCH proxmox{,-backup} 00/10] change of default notification-mode; UX improvements

[Lukas Wagner]

This is intended for the PBS 4.0 release (trixie based).

This patch series changes the default notification mode for PBS to
'notification-system' from the former default of 'legacy-sendmail'.

The rationale for the new default is:
  - 'notification-system' was already used as a default for any datastore 
    created by the GUI
  - consistency, since on PVE, the default is 'auto' (which does not exist
    on PBS, but is equivalent to 'notification-system' unless an email 
    address has been added as well)
  - users are gently nudged to use the new notification stack

The new default affects any datastore/tape backup job that has no explicit
value set. The proxmox-backup part of this series contains migration code which
is invoked from d/postinst to migrate users who relied on the old default to
the appropriate explicit setting.

As mentioned above, the GUI already explicitly set the value to the new default
for a long time. As a result, the changed default mostly affects newly created
datastores/tape jobs which were created via third-party API users or the CLI.

This patch series also contains various UX improvements to make the two
notification modes much easier to understand. The approach is generally the
same as in my series for PVE [1].

[1]: https://lore.proxmox.com/all/20250617084448.87536-1-l.wagner@proxmox.com/T/#t

proxmox:

Lukas Wagner (1):
  pbs-api-types: change default notification mode to
    'notification-system'

 pbs-api-types/src/datastore.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


proxmox-backup:

Lukas Wagner (9):
  cli: manager: move update-to-prune-jobs command to new migrate-config
    sub-command
  cli: manager: add 'migrate-config default-notification-mode' command
  d/postinst: migrate notification mode default on update
  ui: datastore options view: switch to new notification-mode default
  ui: tape backup job: move notification settings to a separate tab
  ui: one-shot tape backup: use same wording as tape-backup jobs
  ui: datastore options: notifications: use same jargon as tape-jobs and
    PVE
  ui: datastore options: drop notify and notify-user rows
  ui: datastore options: notification: use radio controls to select mode

 debian/postinst                               |   9 +-
 src/bin/proxmox-backup-manager.rs             |   6 +-
 .../proxmox_backup_manager/migrate_config.rs  | 171 ++++++++++++++++++
 src/bin/proxmox_backup_manager/mod.rs         |   1 +
 src/bin/proxmox_backup_manager/prune.rs       |  87 +--------
 www/datastore/OptionView.js                   |  33 +---
 www/tape/window/TapeBackup.js                 |  10 +-
 www/tape/window/TapeBackupJob.js              | 109 ++++++-----
 www/window/NotifyOptions.js                   |  43 +++--
 9 files changed, 292 insertions(+), 177 deletions(-)
 create mode 100644 src/bin/proxmox_backup_manager/migrate_config.rs


Summary over all repositories:
  10 files changed, 293 insertions(+), 178 deletions(-)

-- 
Generated by git-murpp 0.8.1