[pbs-devel] [PATCH v2 proxmox 1/4] pbs api types: extend garbage collection status by cache stats

[Fabian Grünbichler]

On May 19, 2025 7:55 am, Christian Ebner wrote:
> Add the number of cache hits and cache misses encountered during
> phase 1 of garbage collection in order to display this information
> in the garbage collection task log summary.
> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> changes since version 1:
> - no changes
> 
>  pbs-api-types/src/datastore.rs | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
> index 5bd953ac..4fb1eb80 100644
> --- a/pbs-api-types/src/datastore.rs
> +++ b/pbs-api-types/src/datastore.rs
> @@ -1459,6 +1459,10 @@ pub struct GarbageCollectionStatus {
>      pub removed_bad: usize,
>      /// Number of chunks still marked as .bad after garbage collection.
>      pub still_bad: usize,
> +    /// Number of atime update cache hits
> +    pub cache_hits: usize,
> +    /// Number of atime update cache misses
> +    pub cache_misses: usize,

this breaks parsing the GC status file on upgrades:

Jun 04 14:58:00 yuna proxmox-backup-proxy[1285990]: error reading gc-status: missing field `cache-hits` at line 1 column 269

reverting the dedup factor to the default of 1..

do we want to mark them as optional?

>  }
>  
>  #[api(
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>