[pbs-devel] [PATCH proxmox-backup] api: datastore: add missing log context for prune

Gabriel Goller g.goller at proxmox.com
Tue Jan 28 11:21:36 CET 2025


On 27.01.2025 14:38, Christian Ebner wrote:
>Adds the missing log context for cases were a prune is not executed
>as dedicated tokio task.
>
>Commit 432de66a ("api: make prune-group a real workertask") moved the
>prune group logic into it's own tokio task conditionally.
>
>However, the log context was missing for cases where no dedicated
>task/thread is started, leading to the worker task state being
>unknown after finish, as no logs are written to the worker task log
>file.

I had a feeling the "task-less" prune job would come back to haunt us,
and sure enough, here we are :(.

Fix looks good though, let's hope we can remove this in the next release
anyway.

Consider:
Reviewed-by: Gabriel Goller <g.goller at proxmox.com




More information about the pbs-devel mailing list