[pbs-devel] applied: [PATCH proxmox-backup] Revert "fix #5710: api: backup: stat known chunks on backup finish"

[Fabian Grünbichler]

On January 13, 2025 11:47 am, Christian Ebner wrote:
> On 1/13/25 11:36, Fabian Grünbichler wrote:
>> we should probably spec out some potential replacement approaches?
> 
> Agreed, but I would nevertheless argue for reverting this for the time 
> being: a new approach will not use the same logic. What do you suggest?

yes, the revert is already applied now :)

we discussed some potential approaches internally a few weeks back, IIRC
some potential mechanisms:

A) actively mark all snapshots referencing a certain chunk as corrupt
when we detect the chunk corruption probably needs to be combined with
some sort of reverse-map from chunk to list of snapshots to scale.


B) mark all snapshots in the chain after the corruption as potentially
corrupt (new state) and incorporate that into the reverify logic to
detect other snapshots with a high likelihood of being affected quickly

C) notify active backup writers of chunks or snapshots being marked as
corrupt. chunks can be cross-referenced at the end with re-used chunks,
snapshots could trigger stat logic similar to the one we just reverted
in case the snapshot is in the same group as the backup writer

D) ..?