[pbs-devel] applied: [PATCH proxmox] pbs api types: relax influx organization and bucket length
Wolfgang Bumiller
w.bumiller at proxmox.com
Thu Feb 20 16:13:33 CET 2025
applied, thanks
On Thu, Feb 20, 2025 at 11:24:01AM +0100, Christian Ebner wrote:
> Relax the length limit for organization and bucket name for InfluxDB
> metric servers in Proxmox Backup Server.
>
> Commit 57fa20406 ("pbs-api-types: add metrics api types") introduced
> the api schema definition for InfluxDB metric servers, limiting the
> name of the organization and the name of the bucket to a length of 3,
> most likely as a result of reusing the same values as for the
> corresponding config id schema restrictions.
>
> This is however not enforced by the InfluxDB REST api [0, 1] and
> stricter than what is defined in Proxmox VE [2].
>
> Reported in the community forum [3].
>
> [0] https://docs.influxdata.com/influxdb/v2/api/#operation/PostOrgs
> [1] https://docs.influxdata.com/influxdb/v2/api/#operation/PostBuckets
> [2] https://git.proxmox.com/?p=pve-manager.git;a=blob;f=PVE/Status/InfluxDB.pm;h=13a96711e766e2f1ea71424ed6d9d8ec8450504c;hb=HEAD#l24
> [3] https://forum.proxmox.com/threads/162521/
>
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> pbs-api-types/src/metrics.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/pbs-api-types/src/metrics.rs b/pbs-api-types/src/metrics.rs
> index 014e28e4..ee901276 100644
> --- a/pbs-api-types/src/metrics.rs
> +++ b/pbs-api-types/src/metrics.rs
> @@ -12,13 +12,13 @@ pub const METRIC_SERVER_ID_SCHEMA: Schema = StringSchema::new("Metrics Server ID
> .schema();
>
> pub const INFLUXDB_BUCKET_SCHEMA: Schema = StringSchema::new("InfluxDB Bucket.")
> - .min_length(3)
> + .min_length(1)
> .max_length(32)
> .default("proxmox")
> .schema();
>
> pub const INFLUXDB_ORGANIZATION_SCHEMA: Schema = StringSchema::new("InfluxDB Organization.")
> - .min_length(3)
> + .min_length(1)
> .max_length(32)
> .default("proxmox")
> .schema();
> --
> 2.39.5
More information about the pbs-devel
mailing list