[pbs-devel] [PATCH proxmox-backup 8/9] ui: expose GC wait period in datastore tuning option

Christian Ebner c.ebner at proxmox.com
Wed Feb 19 17:48:46 CET 2025


Allows to set the wait period for phase 2 of garbage collection in
the datastores tuning parameters. This value changes the time after
which a chunk is not considered in use anymore if it falls outside
of the cutoff window.

Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
---
changes since version 1:
- not present in previous version

 www/Utils.js                | 5 +++++
 www/datastore/OptionView.js | 9 +++++++++
 2 files changed, 14 insertions(+)

diff --git a/www/Utils.js b/www/Utils.js
index f782de43c..d85b45e85 100644
--- a/www/Utils.js
+++ b/www/Utils.js
@@ -850,6 +850,11 @@ Ext.define('PBS.Utils', {
 	delete tuning['gc-atime-check'];
 	options.push(`${gettext('GC atime Check')}: ${gc_atime_check ?? true}`);
 
+	let gc_wait_period = tuning['gc-wait-period'];
+	delete tuning['gc-wait-period'];
+	gc_wait_period = gc_wait_period ?? '1445';
+	options.push(`${gettext('GC Wait Period')}: ${gc_wait_period}m`);
+
 	for (const [k, v] of Object.entries(tuning)) {
 	    options.push(`${k}: ${v}`);
 	}
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index a3e57b0e7..7dea0b37f 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -279,6 +279,15 @@ Ext.define('PBS.Datastore.Options', {
 			    uncheckedValue: 0,
 			    deleteDefaultValue: true,
 			},
+			{
+			    xtype: 'proxmoxintegerfield',
+			    emptyText: Proxmox.Utils.defaultText,
+			    name: 'gc-wait-period',
+			    minValue: 5,
+			    maxValue: 1445,
+			    fieldLabel: gettext('GC Wait Period (min)'),
+			    deleteEmpty: true,
+			},
 		    ],
 		},
 	    },
-- 
2.39.5





More information about the pbs-devel mailing list