[pbs-devel] [PATCH proxmox v2 1/4] log: rename/move init functions

Gabriel Goller g.goller at proxmox.com
Tue Feb 18 17:15:39 CET 2025


>> > >  * pbs tape pmt
>> > >  * pbs tape pmtx
>> > >  * pbs client
>> > >  * pbs pxar
>> > >  * pbs proxmox-backup-debug
>> > >  * pbs proxmox-backup-manager
>> > >  * pbs proxmox-backup-tape
>> > >  * pbs sg-tape-cmd
>> >
>> > ^ IIRC all of these are CLI tools and should therefore all be case (2) -
>> > although I don't know about how the tape stuff works.
>> > If they do anything else, it would be good to know why and have this
>> > documented either in proxmox-log or in their logging-init functions.
>>
>> All except the proxmox-backup-manager as far as I can see, because that
>> one starts pbs tasks directly.
>>
>> > >  * pbs proxmox-daily-update
>> >
>> > The 'daily-update' may be a special case and could use the journal
>> > directly, but may as well be stderr->journald via its `.service`.
>> > But, yeah, obviously it would make actual tracing/debugging easier with
>> > a proper journald-logger here. So another user of case (1).
>>
>> Agree.

Nevermind actually, proxmox-daily-update calls a workertask, so we need
journald and tasklog layer, similar to the daemon's setup.

Sent a new series: https://lore.proxmox.com/pve-devel/20250218161311.558674-1-g.goller@proxmox.com/




More information about the pbs-devel mailing list