[pbs-devel] [PATCH backup v3 0/2] fix #5946: disks: wipe: ensure GPT header backup is wiped

Filip Schauer f.schauer at proxmox.com
Wed Feb 12 11:58:53 CET 2025


When wiping a block device with a GUID partition table, the header
backup might get left behind at the end of the disk. This commit also
wipes the last 4096 bytes of the disk, making sure that a GPT header
backup is erased, even from disks with 4k sector sizes.

Changed since v2:
* Split changes related to replacing calls to dd with direct file writes
  and changes related to wiping the end of the disk into two commits.
* Remove change to only zero out the first 1 MiB instead of the first
  200 MiB

Changed since v1:
* Use `std::os::unix::fs::FileExt::write_all_at` instead of calling `dd`
* only zero out the first 1 MiB

Filip Schauer (2):
  disks: wipe: replace dd with write_all_at for zeroing disk
  fix #5946: disks: wipe: ensure GPT header backup is wiped

 src/tools/disks/mod.rs | 49 +++++++++++++++++++++++-------------------
 1 file changed, 27 insertions(+), 22 deletions(-)

-- 
2.39.5





More information about the pbs-devel mailing list