[pbs-devel] [PATCH backup v2 1/2] fix #5946: disks: wipe: ensure GPT header backup is wiped

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Feb 11 19:39:24 CET 2025


Am 11.02.25 um 17:26 schrieb Filip Schauer:
> When wiping a block device with a GUID partition table, the header
> backup might get left behind at the end of the disk. This commit also
> wipes the last 4096 bytes of the disk, making sure that a GPT header
> backup is erased, even from disks with 4k sector sizes.

change-wise I'd have preferred switching over from dd to writing ourself
in a first patch and then adding the code for clearing the GPT backup header
in a second patch, that's much easier to process and review compared to
mixing those two things.

The resulting code itself looks OK to me though.




More information about the pbs-devel mailing list