[pbs-devel] applied: [PATCH proxmox-backup] verify: handle manifest update errors as non-fatal
Thomas Lamprecht
t.lamprecht at proxmox.com
Mon Feb 10 11:47:47 CET 2025
Am 28.01.25 um 12:47 schrieb Christian Ebner:
> Since commit 8ea00f6e ("allow to abort verify jobs") errors
> propagated up to the verify jobs worker call side are interpreted as
> job aborts.
>
> The manifest update did not honor this, leading to the verify job
> being aborted with the misleading log entry:
> `verification failed - job aborted`
>
> Instead, handle the manifest update error non-fatal just like any
> other verification related error, log it including the error message
> and continue verification with the next item.
>
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> src/backup/verify.rs | 18 +++++++++++++-----
> 1 file changed, 13 insertions(+), 5 deletions(-)
>
>
applied, thanks!
I kept your patch as is, keeping this consistently using info-level for now
is fine, should be changed for all log-sites, if wanted. The error context
would not hurt to use in general, but as it doesn't changes anything now
this also might be better suited in a dedicated patch switching more than
just this call-site over.
More information about the pbs-devel
mailing list