[pbs-devel] [PATCH proxmox-backup 6/7] ui: add run-on-mount checkbox to SyncJob form

[Christian Ebner]

On 1/16/25 07:45, Hannes Laimer wrote:
> Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
> ---
>   www/window/SyncJobEdit.js | 23 ++++++++++++++++++++++-
>   1 file changed, 22 insertions(+), 1 deletion(-)
> 
> diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js
> index bcd2f2fb2..2b3660ed9 100644
> --- a/www/window/SyncJobEdit.js
> +++ b/www/window/SyncJobEdit.js
> @@ -177,7 +177,7 @@ Ext.define('PBS.window.SyncJobEdit', {
>   			fieldLabel: gettext('Sync Schedule'),
>   			xtype: 'pbsCalendarEvent',
>   			name: 'schedule',
> -			emptyText: gettext('none (disabled)'),
> +			emptyText: gettext('none'),
>   			cbind: {
>   			    deleteEmpty: '{!isCreate}',
>   			    value: '{scheduleValue}',
> @@ -191,6 +191,27 @@ Ext.define('PBS.window.SyncJobEdit', {
>   			submitAutoScaledSizeUnit: true,
>   			// NOTE: handle deleteEmpty in onGetValues due to bandwidth field having a cbind too
>   		    },
> +		    {
> +			fieldLabel: gettext('Run when mounted'),
> +			xtype: 'proxmoxcheckbox',
> +			name: 'run-on-mount',
> +			autoEl: {
> +			    tag: 'div',
> +			    'data-qtip': gettext('Run this job when a relevant removable datastore is mounted'),
> +			},
> +			uncheckedValue: false,
> +			value: false,
> +			listeners: {
> +			    change: function(checkbox, runOnMount) {
> +				let me = this;
> +				let form = me.up('pbsSyncJobEdit');
> +				let scheduleField = form.down('field[name=schedule]');
> +				if (runOnMount) {
> +				    scheduleField.clearValue();

clearing the schedule field's value is not enough. Clicking the checkbox 
should also disable that field, as otherwise one can re-add a schedule 
after setting the flag. Further, if this is a requirement, setting and 
getting the sync job config should also include a check for that?

Although I'm not sure it is really required for a sync job which runs on 
mount to not be also be able to run on schedule?

> +				}
> +			    },
> +			},
> +		    },
>   		],
>   
>   		column2: [