[pbs-devel] applied: [PATCH proxmox-backup] garbage collection: allow to abort or shutdown on phase 2 for s3 stores

Fabian Grünbichler f.gruenbichler at proxmox.com
Wed Dec 10 12:12:16 CET 2025


On Fri, 28 Nov 2025 16:41:21 +0100, Christian Ebner wrote:
> Currently only phase 1 and phase 3 can be aborted on s3 backed
> datastores.
> 
> Safely abort phase 2 after each processed s3 object key. Doing that
> after each key is possible since the chunk is already cleaned up from
> the local datastore cache after each iteration. While it might not
> have been cleaned up from the s3 backend, this leaves it in the same
> state as if after a datastore re-creation from previous S3 contents,
> where the local marker is also not present. So either the chunk will
> be cleaned up by the subsequent garbage collection run or overwritten
> by reupload and marker file re-insertion if a concurrent backup
> writer adds it again in the meantime.
> 
> [...]

Applied, thanks!

[1/1] garbage collection: allow to abort or shutdown on phase 2 for s3 stores
      commit: 5e3f7e26a70d13f801d50cd968bff9da2d2ef54f

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler at proxmox.com>




More information about the pbs-devel mailing list