[pbs-devel] superseded: [PATCH proxmox 1/8] cargo: bump msrv to 1.87
Maximiliano Sandoval
m.sandoval at proxmox.com
Wed Dec 10 11:57:05 CET 2025
Thomas Lamprecht <t.lamprecht at proxmox.com> writes:
> Am 10.12.25 um 09:40 schrieb Maximiliano Sandoval:
>> Thomas Lamprecht <t.lamprecht at proxmox.com> writes:
>>
>>> Am 09.12.25 um 11:53 schrieb Maximiliano Sandoval:
>>>> proxmox-fixed-string uses std::str::from_utf8_unchecked which was
>>>> stabilized on 1.87, see its announcement [1].
>>>>
>>>> [1] https://blog.rust-lang.org/2025/05/15/Rust-1.87.0/
>>>
>>> Shouldn't proxmox-fixed-string then get that msrv bump though?
>>
>> We can do that, but then it becomes a bit unruly to manage a per crate
>> msrv. I'll send a patch doing that.
>
> IMO having to manually track where a dependency that requires higher
> msrv is used is *much* harder and error prone than declaring that relation
> for where it's actually used. I.e., with your patch we're still missing
> PDM, pve-rs, ...?
>
> On the contrary, if you declare dependency info for proxmox-fixed-string,
> then debcargo will automatically generate a d/control dependency relation
> like:
>
> rustc:native (>= 1.87) <!nocheck>,
>
> Thus everything using that as build-dependency will get ensure the
> correct rustc version is installed for all users of that crate, not
> just one.
Superseded-by: https://lore.proxmox.com/all/20251210105615.215532-1-m.sandoval@proxmox.com/
--
Maximiliano
More information about the pbs-devel
mailing list