[pbs-devel] [PATCH proxmox-backup v3] restrict consent-banner text length

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Apr 8 15:08:18 CEST 2025


Am 08.04.25 um 15:01 schrieb Gabriel Goller:
> On 08.04.2025 14:58, Gabriel Goller wrote:
>> On 08.04.2025 13:08, Thomas Lamprecht wrote:
>>> Am 10.12.24 um 16:53 schrieb Gabriel Goller:
>>>> Add a maxLength in of 63*1024 in the frontend. We allow a max body
>>>> size of 64*1204 in the api and to allow some other properties to
>>>> coexist, reserve 1024 characters. In the backend we set the limit to
>>>> 128000 (128kB), which is the same as in pve.
>>>
>>> I reduced it in PVE a bit again; might also make sense to increase the
>>> max POST size to 512 KiB just like in PVE, the rust based HTTP server
>>> should handle these sizes without a sweat if the perl one can do that.
>>
>> I'll send a patch soon with a limit of 64kB on both frontend and api.
>> The increasing of the max body size is IMO better in a future patch as
>> that will need some testing.
> 
> *63kB oops, we still need to let some room for other properties.

That's why I'd increase the post size limit, it's a trivial logical
check, not really sure what's much to test there?




More information about the pbs-devel mailing list