[pbs-devel] [PATCH v5 proxmox-backup 0/4] fix #2996: client: allow optional match patterns for restore

Christian Ebner c.ebner at proxmox.com
Wed Sep 18 17:27:12 CEST 2024


This patches implement the api types to allow input validation for
pathpatterns and reuse them in the pxar-bin, the catalog shell as
well as the newly exposed optional restore patterns to the backup
clients restore command.

Patterns are parsed and passed along to the preexisting restore
logic via the `PxarExtractOptions`.

changes since version 4:
- rebased onto current master
- fixed passing patterns via cli for pxar extract

changes since version 3:
- s/matches/patterns for bail message, thanks for testing and
  catching this Gabriel!

changes since version 2:
- added API types as suggested
- reuse same API types for proxmox-backup-client catalog shell and
  restore as well as the pxar extract
- use simple reference instead of `as_slice()` when passing vector of
  patterns

Link to bugtracker issue:
https://bugzilla.proxmox.com/show_bug.cgi?id=2996

Christian Ebner (4):
  api-types: implement dedicated api type for match patterns
  pxar: bin: use dedicated api type for restore pattern
  client: catalog shell: use dedicated api type for patterns
  fix #2996: client: allow optional match patterns for restore

 pbs-api-types/src/lib.rs          |  3 ++
 pbs-api-types/src/pathpatterns.rs | 55 +++++++++++++++++++++++++++++++
 pbs-client/src/catalog_shell.rs   |  7 ++--
 proxmox-backup-client/src/main.rs | 29 +++++++++++++---
 pxar-bin/Cargo.toml               |  1 +
 pxar-bin/src/main.rs              | 26 +++++++--------
 6 files changed, 99 insertions(+), 22 deletions(-)
 create mode 100644 pbs-api-types/src/pathpatterns.rs

-- 
2.39.2





More information about the pbs-devel mailing list