[pbs-devel] [PATCH proxmox{, -backup}/widget-toolkit v4 0/7] fix #5463: add optional consent banner before login
Gabriel Goller
g.goller at proxmox.com
Fri Sep 13 15:10:26 CEST 2024
The consent text is stored in the node.cfg config file and is encoded
using base64. This allows us to support multi-line strings and special
characters. To easily edit the text a new edit-field called
ProxmoxTextAreaField has been introduced. It supports editing and saving
multi-line text and converting it to its base64 representation.
The same implementation will be ported to pve and eventually pmg in
the foreseeable future.
v4:
- rebase
v3, thanks @Dominik, @Thomas:
- store text with base64 instead of URI-encoding
- improve content popup sizing
- support markdown
v2, thanks @Thomas, @Dominik:
- remove consent.txt file, move to node.cfg config
- add ui option to insert consent text
- encode text with encodeURI/decodeURI
v1, thanks @Dominik:
- embed consent text into index.html file instead of extra api request
- removed decline button
- added alwaysOnTop property to popup
widget-toolkit:
Gabriel Goller (3):
utils: add base64 conversion helper
window: add consent modal
form: add support for multiline textarea
src/Makefile | 2 ++
src/Utils.js | 18 ++++++++++++
src/form/TextAreaField.js | 60 ++++++++++++++++++++++++++++++++++++++
src/grid/ObjectGrid.js | 29 ++++++++++++++++++
src/window/ConsentModal.js | 36 +++++++++++++++++++++++
5 files changed, 145 insertions(+)
create mode 100644 src/form/TextAreaField.js
create mode 100644 src/window/ConsentModal.js
proxmox:
Gabriel Goller (1):
rest-server: add custom handlebars escape fn
proxmox-rest-server/src/api_config.rs | 28 ++++++++++++++++++++++++++-
1 file changed, 27 insertions(+), 1 deletion(-)
proxmox-backup:
Gabriel Goller (3):
api: add consent api handler and config option
ui: show consent banner before login
docs: add section about consent banner
docs/gui.rst | 8 ++++++++
src/api2/node/config.rs | 8 ++++++++
src/bin/proxmox-backup-proxy.rs | 11 ++++++++---
src/config/node.rs | 4 ++++
www/LoginView.js | 12 ++++++++++++
www/config/NodeOptionView.js | 6 ++++++
www/index.hbs | 1 +
7 files changed, 47 insertions(+), 3 deletions(-)
Summary over all repositories:
13 files changed, 219 insertions(+), 4 deletions(-)
--
Generated by git-murpp 0.7.1
More information about the pbs-devel
mailing list