[pbs-devel] [PATCH v5 proxmox-backup 06/31] api types: implement remote acl path method for sync job

Christian Ebner c.ebner at proxmox.com
Mon Oct 28 16:13:41 CET 2024


On 10/28/24 12:04, Fabian Grünbichler wrote:
> On October 25, 2024 2:46 pm, Christian Ebner wrote:
>> On 10/25/24 13:44, Fabian Grünbichler wrote:
>>
>> Therefore I did not use the pre-existing helper. Or did you intend for
>> the helper to be adapted accordingly, by e.g. passing an optional remote?
> 
> ah right, missed that.. that's probably not worth it just for the two
> call sites.. I guess we could just replace the first member of the Vec,
> but that also seems a bit risky in case of an overhaul of the ACL paths
> down the line.. so let's keep this (mostly) as it is :)

In the end I opted for adding a BackupNamespace::remote_acl_path here 
and factoring out the common part from BackupNamespace::acl_path. That 
does help also with the readability at the call sites.




More information about the pbs-devel mailing list