[pbs-devel] [PATCH v5 proxmox-backup 24/31] ui: sync view: do not use data model proxy for store

[Dominik Csapak]

one comment inline

On 10/18/24 10:42, Christian Ebner wrote:
> In order to load data using the same model from different sources,
> set the proxy on the store instead of the model.
> This allows to use the view to display sync jobs in either pull or
> push direction, by setting the additional `sync-direction` parameter
> to the proxy's api calls.
> 
> Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> ---
> changes since version 4:
> - no changes
> 
> changes since version 3:
> - no changes
> 
>   www/config/SyncView.js | 9 ++++-----
>   1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/www/config/SyncView.js b/www/config/SyncView.js
> index 981b9b251..39e464fc5 100644
> --- a/www/config/SyncView.js
> +++ b/www/config/SyncView.js
> @@ -16,10 +16,6 @@ Ext.define('pbs-sync-jobs-status', {
>   	'comment',
>       ],
>       idProperty: 'id',
> -    proxy: {
> -	type: 'proxmox',
> -	url: '/api2/json/admin/sync',
> -    },
>   });
>   
>   Ext.define('PBS.config.SyncJobView', {
> @@ -160,9 +156,12 @@ Ext.define('PBS.config.SyncJobView', {
>   	sorters: 'id',
>   	rstore: {
>   	    type: 'update',
> -	    storeid: 'pbs-sync-jobs-status',

why is the storeid here removed? the commit message does not mentions this

>   	    model: 'pbs-sync-jobs-status',
>   	    interval: 5000,
> +	    proxy: {
> +		type: 'proxmox',
> +		url: '/api2/json/admin/sync',
> +	    },
>   	},
>       },
>