[pbs-devel] [PATCH v3 proxmox-backup 0/5] introduce dedcated archive name api type

Gabriel Goller g.goller at proxmox.com
Thu Oct 24 11:21:00 CEST 2024


On 24.10.2024 10:01, Christian Ebner wrote:
>There is currently no dedicated api type for the archive names, given
>as input parameters to several api methods.
>
>This patches introduce a dedicated type for archive names, in order
>to collect the code for checks and eventual mappings into one
>location and reduce possible unintentional misuse by passing
>incorrect argument values to the functions and methods consuming
>the archive names.
>
>As a positive side effect, the mapping now allows also for the server
>archive type extensions to be optionally passed as input to several
>commands, e.g.
>```
>proxmox-backup-client restore <snapshot> <name>.pxar.didx <target>
>```
>is now valid, being equal to
>```
>proxmox-backup-client restore <snapshot> <name.pxar <target>
>```
>
>@Gabriel: Did not include your git trailers since there was some
>rebasing, please double check if the changes are still fine by you.

Not a thorough review, just a quick glance over the changes – which seem
fine. Also did a quick test with proxmox-backup-client
restore/mount.

Consider:
Tested-by: Gabriel Goller <g.goller at proxmox.com>




More information about the pbs-devel mailing list