[pbs-devel] [PATCH proxmox-backup 0/3] backup client progress log interval

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Oct 22 07:35:06 CEST 2024


Am 21/10/2024 um 18:06 schrieb Christian Ebner:
> If going for two different optional parameters, one question remains 
> however: how to handle the no logging case? Should a 0 value indicate 
> that or do we want another explicit flag for that?

Adding new variants is easier than removing existing ones, so for now
I'd go with using a zero interval for that.
If there are requests we can add either a special value, or maybe even
nicer a separate `--no-progress-log` switch, or with a similar name,
like e.g. an alternative could be `--no-progress-interval`.

>> Oh, and in above examples I also dropped the "log" as while it certainly
>> doesn't hurt its IMO also not really required to be able to understand what
>> it's for.
> 
> Agreed! Thank you for your comments.

After having written above w.r.t. the disable-switch option I see a bit
more value in having "log" compared to yesterday, but no hard feelings
either way, let's not get hung up on this – you decide.




More information about the pbs-devel mailing list