[pbs-devel] applied: [PATCH v3 proxmox-backup] partial fix #5560: client: periodically show backup progress

[Thomas Lamprecht]

Am 17/10/2024 um 17:53 schrieb Christian Ebner:
> On 10/17/24 17:02, Thomas Lamprecht wrote:
>> applied, thanks! With some opinionated line-reduction as follow-up (opinionated
>> because it was OK as is too, and I could have noticed that on the previous
>> review, sorry...)
>>
>> Did not think it through at all, but maybe it makes sense to add the uploaded
>> size also to the upload stats.
> 
> For now I do not see much benefit for this, as after consuming the full 
> upload stream there are no more chunks queued for upload, so the 
> counters already present in `UploadStats` contain the same information.
> 
> And this information is already shown to the user at the end of the 
> upload as, e.g.:
> ```
> had to backup 1.66 GiB of 285.242 GiB (compressed 1.274 GiB) in 58.52 s 
> (average 29.053 MiB/s)
> ```

Ack, thanks for clearing this up to me.