[pbs-devel] applied: [PATCH v3 proxmox] time: drop trailing space when not showing seconds at end

Christian Ebner c.ebner at proxmox.com
Thu Oct 17 16:40:19 CEST 2024


On 10/17/24 15:16, Thomas Lamprecht wrote:
> applied this one, thanks!
> 
> FYI: I found a bug within the Display code, months got printed with the
> "m" unit, which is the unit for minutes. Besides fixing that I also made
> it print "m" for minutes now to have more consistent unit variants (all
> single letter) see the commit message for more details.
> 
> I also added a basic module documentation to convey what the format is and
> where it comes from and some basic unit tests, could be surely expanded
> though.

Great! So should we maybe start to switch over time duration output in 
the backup client logs to `TimeSpan`s display output?
There are a few places where purely seconds are used.




More information about the pbs-devel mailing list