[pbs-devel] [PATCH v3 proxmox-backup 32/33] api: datastore/namespace: return backup groups delete stats on remove

[Christian Ebner]

On 10/11/24 11:32, Fabian Grünbichler wrote:
> On September 12, 2024 4:33 pm, Christian Ebner wrote:
>> @@ -299,10 +302,9 @@ pub async fn delete_group(
>>   
>>           let delete_stats = datastore.remove_backup_group(&ns, &group)?;
>>           if !delete_stats.all_removed() {
>> -            bail!("group only partially deleted due to protected snapshots");
>> +            warn!("group only partially deleted due to protected snapshots");
> 
> this not only changes the return type (from nothing to something
> actionable, which is okay!) but also the behaviour..
> 
> right now with this series applied, if I remove a group with protected
> snapshots, I get no indication on the UI that it failed to do so, and
> the log message only ends up in journal since there is no task context
> here..
> 
> I think this would at least warrant opt-in for the new behaviour? in any
> case, the warning/error could probably be adapted to contain the counts
> at least, now that we have them ;)

Yeah, right, opt-in seems the best way to go, as otherwise getting back 
the stats for the sync job will not work..

Same for the other case...