[pbs-devel] [PATCH proxmox-backup 1/2] api types: version: add helper for min version checks

Christian Ebner c.ebner at proxmox.com
Thu Nov 28 14:14:27 CET 2024


On 11/28/24 14:10, Thomas Lamprecht wrote:
> Why not impl the Ord trait here instead?
> 
> Then the call-site could be
> 
> let supports_prune_delete_stats = api_version >= ApiVersion::new(3, 2, 11, String::new());

Ah, yes that's way nicer and allows also for exact version matching.

> And maybe a separate type for the triple without the commit hash on which you
> also impl the same and then avoid that slightly confusing String::new() hack.

Acked, will send a new version incorporating your feedback, thanks!





More information about the pbs-devel mailing list