[pbs-devel] [PATCH proxmox-backup 2/2] api: disks: directory: fail if mount unit already exists

[Thomas Lamprecht]

Am 27.11.24 um 16:23 schrieb Shannon Sterz:
> On Wed Nov 27, 2024 at 4:06 PM CET, Fiona Ebner wrote:
>> +    if std::path::PathBuf::from(&mount_unit_path).exists() {
>> +        bail!("systemd mount unit {mount_unit_path:?} already exists");
> 
> nit: relying on the `Debug` trait here to quote the string feels a bit..
> hacky to me? maybe just:
> 
> ```rs
> bail!("systemd mount unit \"{mount_unit_path}\" already exists");
> ```
> 
> or use single quotes as we do elsewhere.
> 

FWIW, we (mis)use this semi-frequently already, it might not be the cleanest
thing but works out OK; I'm fine either way, just wanted to mention that if
this really has some issue, or is considered non-idiomatic, then a tree-wide
clean-up would be warranted, otherwise its usage will probably grow due to
copying existing code as base for new dev work.