[pbs-devel] applied: [RFC proxmox-backup 2/2] GC: add check for nested datastore

[Thomas Lamprecht]

Am 27.11.24 um 15:11 schrieb Fabian Grünbichler:
> these are particularly problematic since GC will walk the whole datastore tree
> on the file system, and will thus pick up indices (but not chunks!) from nested
> directories that are ignored in other code paths that use our regular
> iterators..
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> ---
> 
> Notes:
>     a similar check might also be sensible for mounting and should now be fairly
>     easy to implement there as well..
> 
>  pbs-datastore/src/datastore.rs | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
>

applied, thanks!

It's a sensible improvement and cost is low, especially compared to what GC does
in general. That said, it's naturally not a silver bullet, through a symlink or
bind mount one could construct a datastore that would not be detected, but
probably obvious to you already so just mentioning for the sake of completeness.