[pbs-devel] applied: [PATCH proxmox-backup v2] api: add Sys.Modify on /system/disks as permission to endpoints handling removable datastores

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 26 16:25:01 CET 2024


Am 26.11.24 um 15:28 schrieb Hannes Laimer:
> Suggested-by: Fabian Grünbichler <f.gruenbichler at proxmox.com>
> Signed-off-by: Hannes Laimer <h.laimer at proxmox.com>
> ---
> changes since v1:
>  * config: create/delete: only check for Sys.Modify on /system/disks if
>     removable
> 
>  src/api2/admin/datastore.rs  | 12 +++++++++---
>  src/api2/config/datastore.rs | 13 ++++++++++++-
>  2 files changed, 21 insertions(+), 4 deletions(-)
> 
>

applied, with subject slightly improved and the descriptions for the dynamic
access checks squashed in, thanks!

You can send Fabian's other suggestion to switch to Datastore.Modify as
follow-up.




More information about the pbs-devel mailing list