[pbs-devel] [PATCH proxmox-backup-restore-image] kernel: enable codepage 437 for vfat support

[Fabian Grünbichler]

adding missing subject prefix ;)

On November 26, 2024 1:03 pm, Stoiko Ivanov wrote:
> ran into an issue when clicking on the ESP of a VM while trying
> single-file restore.
> 
> the added config-config options are taken from config-6.5.13-6-pve
> (the restore-image is still based on kernel 6.5) - and I tried copying
> a small set around the needed options.

maybe we should upgrade to a newer one at some point (might also benefit
from NTFS bug fixes and added features..)

> 
> with the patch the ESP contents are shown successfully
> 
> Signed-off-by: Stoiko Ivanov <s.ivanov at proxmox.com>
> ---
>  src/config-base | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/config-base b/src/config-base
> index 1581b09..238d93c 100644
> --- a/src/config-base
> +++ b/src/config-base
> @@ -144,6 +144,11 @@ CONFIG_ISO9660_FS=y
>  CONFIG_NTFS3_FS=y
>  CONFIG_MSDOS_FS=y
>  CONFIG_VFAT_FS=y
> +CONFIG_FAT_DEFAULT_CODEPAGE=437
> +CONFIG_FAT_DEFAULT_IOCHARSET="iso8859-1"

these two are the default values anyway and already set without this
patch?

> +CONFIG_NLS=y

this one is set as well

> +CONFIG_NLS_DEFAULT="utf8"

the upstream default for this is iso8859-1, but it also says this is
"the NLS used by your console, not the NLS used by a specific file
system (if different) to store data (filenames) on disk." - whatever
that means exactly?

> +CONFIG_NLS_CODEPAGE_437=y

shouldn't we also enable NLS_UTF8 ?

I mean, I guess it doesn't really matter as long as we don't start
setting the corresponding mount options to force a specific codepage?

the last option seems to be the only one that is actually missing from
our config ;) althoug hit doesn't hurt to set any of the above
explicitly I guess..

>  
>  # memory hotplug
>  CONFIG_MEMORY_HOTPLUG=y
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>