[pbs-devel] [PATCH v4 proxmox-backup] fix #5710: api: backup: stat known chunks on backup finish

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 26 11:12:10 CET 2024


Am 26.11.24 um 08:36 schrieb Christian Ebner:
> On 11/25/24 22:42, Thomas Lamprecht wrote:
>> please include this stuff in the actual commit message, it's nice to see as
>> point-in-time sample when reading the git log.
>> A comparison with bigger disks, say 1 TB, would be additionally great to see
>> how this scales with big disk size.
> 
> Thanks for feedback!
> 
> I decided to not include these in the patch directly, as the tests 
> performed were limited in extend and setup, so I was unsure how 
> representative they actually are.

In such cases it's fine to include them with exactly such a disclaimer.

> I will however keep this in mind for next time, as this has already been 
> applied as is.

The data is out there so already good, I just have a strong preference
of having these things in the commit log too.




More information about the pbs-devel mailing list