[pbs-devel] [PATCH proxmox-backup 0/4] use same config section type for all sync jobs

Christian Ebner c.ebner at proxmox.com
Mon Nov 25 18:40:08 CET 2024


This patch series drops the `sync-push` config section type in favor of
using the same `sync` for both, sync jobs in push and pull direction.
Instead, encode the sync direction as optional parameter in the sync job
config, defaulting to sync in pull direction. This reduces complexity by
allowing to drop the optional parameter for most function calls.
For api methods, the default remains to only show sync directions in
pull direction, if no ListSyncDirection::All is passed, or the direction
explicitly selected. This allows to default to show both directions in
future Proxmox Backup Server version.

This patch series depends on Dominik's patch series found here:
https://lore.proxmox.com/pbs-devel/377618fd-0ea9-46ba-9aec-a47387eca50d@proxmox.com/T

Christian Ebner (4):
  config: sync: use same config section type `sync` for push and pull
  api: admin/config: introduce sync direction as job config parameter
  bin: show direction in sync job list output
  api types: drop unused config type helpers for sync direction

 pbs-api-types/src/jobs.rs              |  25 ++--
 pbs-config/src/sync.rs                 |  17 +--
 src/api2/admin/sync.rs                 |  18 +--
 src/api2/config/datastore.rs           |  16 +--
 src/api2/config/notifications/mod.rs   |  19 ++--
 src/api2/config/sync.rs                | 151 ++++++++-----------------
 src/bin/proxmox-backup-proxy.rs        |  22 +---
 src/bin/proxmox_backup_manager/sync.rs |   6 +-
 src/server/sync.rs                     |   2 +-
 9 files changed, 88 insertions(+), 188 deletions(-)

-- 
2.39.5





More information about the pbs-devel mailing list