[pbs-devel] [PATCH proxmox-backup v2] reuse-datastore: avoid creating another default prune job

[Gabriel Goller]

Was a bit too hasty on the previous reply.

On 25.11.2024 15:37, Fabian Grünbichler wrote:
>On November 25, 2024 11:10 am, Christian Ebner wrote:
>> On 11/25/24 09:59, Gabriel Goller wrote:
>>> If a datastore with a default prune job is removed, the prune job is
>>> preserverd as it is stored in /etc/proxmox-backup/prune.cfg. We also
>>> create a default prune job for every datastore – this means that when
>>> reusing a datastore that previously existed, you end up with duplicate
>>> prune jobs.
>>
>> Looking at this once more, I am not so sure anymore that this should
>> only check for the default prune job? Why not check if there is any
>> prune job configured at all for this datastore, and only if there is
>> none create the new default prune job?
>
>that would also work?
>
>- if no prune job exists for this store, create default one
>- if explicit prune job options where given, create that one
>- otherwise, don't add a prune job (no options given, and one exists
>  already for this store)

This is the behavior that we have now?

What I intended with this patch was to ignore the default prune job
created by 'prune schedule' so that we don't create duplicated prune
jobs.