[pbs-devel] partially-applied: [PATCH proxmox-backup 0/4] improve push sync job log messages

Fabian Grünbichler f.gruenbichler at proxmox.com
Fri Nov 22 10:04:55 CET 2024


applied patchs 1, 2 and 4 with some small follow-ups:
- moved the remove snapshot/group success logging into the corresponding code
  path, so that failures don't log twice/wrong information
- replaced the abort for non-owned groups in the last patch with a skip, we
  haven't started uploading yet at that point, so we can't abort anything.

comments for patch 3 in a separate mail.

Quoting Christian Ebner (2024-11-21 16:43:33)
> This is a small series of patches with the intend to improve the log
> messages for the sync job in push direction, mainly adding context to
> error messages from the remote when the error stems from an api call,
> limiting line length and improving usage of consistent terms for better
> readablility and easier understanding.
> 
> Christian Ebner (4):
>   server: push: fix needless borrow clippy warning
>   server: push: consistently use remote over target for error messages
>   server: push: add error context to all target api calls
>   server: push: various smaller improvements to error messages
> 
>  src/server/push.rs | 79 ++++++++++++++++++++++++++++------------------
>  1 file changed, 49 insertions(+), 30 deletions(-)
> 
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
>




More information about the pbs-devel mailing list