[pbs-devel] applied-series: [PATCH v2 proxmox-backup 0/5] fix #5853: ignore stale files

[Fabian Grünbichler]

thanks! this version looks much cleaner now :)

On November 14, 2024 3:41 pm, Christian Ebner wrote:
> When files and their associated metadata get invalidated, I/O
> operations on network filesystems return ESTALE to indicate that the
> filehandle does not reference a valid file anymore.
> 
> Currently, the proxmox-backup-client does not cover such cases, it
> will fail with a hard error when a stale file handle is encountered.
> Any concurrent operation invalidating file handles has the potential
> to lead to the backups failing if timed accordingly. For local
> filesystems this is not an issue, as the file remains accessible
> until the file handle is closed.
> 
> Make the backup client more resilient by handling the ESTALE errors
> gracefully, warning the user about the vanished/invalidated files,
> while generating a valid and consistent backup archive nevertheless.
> 
> Changes since version 1:
> - Avoid tuples in return values by downcasting anyhow::Error to Errno
>   when latter is required
> - Add report stale file handle helper
> - Refactor report vanished/changed file helpers
> 
> Christian Ebner (5):
>   client: pxar: refactor report vanished/changed helpers
>   client: pxar: skip directories on stale file handle
>   client: pxar: skip directory entries on stale file handle
>   client: pxar: warn user and ignore stale file handles on file open
>   fix #5853: client: pxar: exclude stale files on metadata/link read
> 
>  pbs-client/src/pxar/create.rs | 94 +++++++++++++++++++++++++----------
>  1 file changed, 69 insertions(+), 25 deletions(-)
> 
> -- 
> 2.39.5
> 
> 
> 
> _______________________________________________
> pbs-devel mailing list
> pbs-devel at lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> 
> 
>