[pbs-devel] [PATCH v6 proxmox-backup 27/29] api: datastore/namespace: return backup groups delete stats on remove

Christian Ebner c.ebner at proxmox.com
Thu Nov 21 11:00:50 CET 2024


On 11/21/24 10:27, Thomas Lamprecht wrote:
> Am 31.10.24 um 13:15 schrieb Christian Ebner:
>> Add and expose the backup group delete statistics by adding the
>> return type to the corresponding REST API endpoints.
>>
>> Further, add a `error-on-protected` flag to the api endpoints,
>> allowing to return without error when set to false. Default remains
>> enabled.
> 
> This first sounded like it should two patches, but they are related in the
> sense that the other side needs both to differ between "backup went generally
> fine" and "all was OK but could not deleted some snapshots that are protected".
> 
> So please add that rationale, or a better one if I was off, to the commit
> message. As while the "what" can be nice to have a summary without reading
> all the code, the "why" is very important to see how it overall fits into the
> picture (of a series but also the project as a whole) – at lest for me that is.

Okay, will extend this commit message with more reasoning on why to add 
the flag and who it is used by.




More information about the pbs-devel mailing list