[pbs-devel] applied: [PATCH proxmox-backup 1/2] client: pxar: perform match pattern check only once

Christian Ebner c.ebner at proxmox.com
Wed Nov 13 09:23:07 CET 2024


> On 12.11.2024 21:25 CET Thomas Lamprecht <t.lamprecht at proxmox.com> wrote:
> 
>  
> Am 26.09.24 um 14:34 schrieb Christian Ebner:
> > While traversing the filesystem tree, `generate_directory_file_list`
> > generates the list of entries to include for each directory level,
> > already matching the entry against the given list of match patterns.
> > 
> > Since this already excludes entries which should not be included in
> > the archive, the same check in the `add_entry` call is redundant,
> > as it is executed for each entry which is included in the list
> > generated by `generate_directory_file_list`.
> > 
> > Signed-off-by: Christian Ebner <c.ebner at proxmox.com>
> > ---
> > Seems to be present since commit:
> > c443f58b09 ("switch to external pxar and fuse crates")
> 
> feel free to add commit references to the commit message itself.

Acked, will do next time.
Did not include it there directly as it does not really fix anything, just drops redundant code and I investigated why it was introduced like this.

> 
> > 
> > Noticed while looking at the code because an user reported an issue in
> > the community forum, the issue turned out to be unrelated:
> > https://forum.proxmox.com/threads/154995/
> > 
> >  pbs-client/src/pxar/create.rs | 9 ---------
> >  1 file changed, 9 deletions(-)
> > 
> >
> 
> applied series, thanks!




More information about the pbs-devel mailing list