[pbs-devel] applied: [PATCH proxmox-backup v2 1/2] api: avoid retrieving lsblk result twice

Thomas Lamprecht t.lamprecht at proxmox.com
Tue Nov 12 21:18:51 CET 2024


Am 17.09.24 um 10:05 schrieb Gabriel Goller:
> Avoid running `lsblk` twice when executing the `list_disk`
> endpoint/command. This and the various other small nits improve the
> performance of the endpoint.
> 
> Does not really fix, but is related to: #4961.
> 
> Signed-off-by: Gabriel Goller <g.goller at proxmox.com>
> ---
> 
> v2:
>  - nothing
> 
>  src/api2/node/disks/mod.rs    |  6 +++++-
>  src/tools/disks/mod.rs        | 10 +++++++---
>  src/tools/disks/smart.rs      | 10 +++-------
>  src/tools/disks/zfs.rs        | 15 ++++++++-------
>  src/tools/disks/zpool_list.rs |  2 +-
>  5 files changed, 24 insertions(+), 19 deletions(-)
> 
>

applied series, thanks!

While parallelism can also cause issues (load), this should be fine here and
it's only an implementation detail, so we always can change this back without
much hassle anyway.




More information about the pbs-devel mailing list